Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS indicator idle / running #2585

Closed
rusefillc opened this issue Apr 26, 2021 · 2 comments
Closed

TS indicator idle / running #2585

rusefillc opened this issue Apr 26, 2021 · 2 comments
Assignees
@mck1117

Comments

@rusefillc
Copy link
Contributor

Considering the importance and complexity of idle control we need a top level TS indicator "idle/running"
@rusefillc
Copy link
Contributor Author

@mck1117 what's the idea behind existing

tsOutputChannels.isIdleClosedLoop = phase == Phase::Idling && CONFIG(idleMode) == IM_AUTO;

?

It's very tempting to replace it with

tsOutputChannels.isIdleLoop = phase == Phase::Idling

since the CONFIG(idleMode) == IM_AUTO part user should see in config?

@rusefillc
Copy link
Contributor Author

@mck1117 poke

@mck1117 mck1117 mentioned this issue May 13, 2021
Merged
@mck1117 mck1117 closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mck1117 mck1117

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mck1117 @rusefillc