-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect instant RPM immediately after VVT resync #4463
Comments
Somewhat related question: could this be happening to other triggers with VVT? |
short answer: it's complicated Miata NB2 is "double symmetrical, 180 degrees symmetrical" so it's not exactly the same as say hyuindai 60/2 |
@rusefillc it can happy with any crank pattern resolved by cam position, including 60-2 crank plus cam |
remember a 360 degree crank pattern is still ambiguous, not just symmetrical crank options |
Ah hah, looks like #4544 probably worked - that little flat spot with the blue arrow is the portion after reset where we simply don't calculate RPM for ~90 degrees until we get more data, avoiding the weird blip. |
https://rusefi.com/online/view.php?log=1037 Seems perfect now, I love you |
Seen in this log: https://rusefi.com/online/view.php?log=983
Consider the event marked
1
. At that instant, a vvt resync happened, resolving ambiguous crank position using cam information. This produced a discontinuity in the engine phase, which means we start comparing against the wrong teeth in the past to compute instant RPM. In this case, the "true" RPM at the skip was ~180, but since we started looking at the wrong spot in the trigger cycle to compute instant RPM, we came up with only 45 rpm, until the engine had come around again and written values in the correct positions.The text was updated successfully, but these errors were encountered: