Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD card data rate #4553

Closed
rusefillc opened this issue Sep 9, 2022 · 7 comments · Fixed by #4837
Closed

SD card data rate #4553

rusefillc opened this issue Sep 9, 2022 · 7 comments · Fixed by #4837
Assignees

Comments

@rusefillc
Copy link
Contributor

https://rusefi.com/online/view.php?log=1022 seems to be an example of a data log showing only 19Hz rate

SD Card Logger -> SD Card Logger default value is 50ms which means 1000 / 50 = 20Hz seems to align well!

@rusefillc
Copy link
Contributor Author

@BeerMoneyMotorsports since you drive can you try lower period maybe 10ms or 3ms?

@mck1117 do you still drive any rusEFI vehicles periodically?

@rusefillc
Copy link
Contributor Author

@BeerMoneyMotorsports poke did you have a chance to put any miles with lower period/higher frequency?

@mck1117 are you ever driving anything, what's your take on rate and period?

@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

He's had it turned off for a bit since the hang bug.

I logged all weekend with SD at 20hz, didn't have a reason to go faster (also knowing that the bug exists). That said I'll probably turn it up to ~50hz now that the bug is fixed.

Do we think there is a code change that should happen? 20hz seems like a reasonable balance between "collect useful engine data" and "not too much storage" to me.

@rusefillc
Copy link
Contributor Author

The only code change would be to change the hard-coded default value '50 ms'

@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

I would also support a change to hz instead of ms. TS lets you pick hz, so why don't we?

@rusefillc
Copy link
Contributor Author

we can switch logic from ms to hz and keep config location, effectively migrating everyone from 50ms to 50hz :)

too nasty?

@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

evil, I like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants