Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC and SD logs #4556

Open
rusefillc opened this issue Sep 9, 2022 · 15 comments
Open

RTC and SD logs #4556

rusefillc opened this issue Sep 9, 2022 · 15 comments
Assignees
Labels

Comments

@rusefillc
Copy link
Contributor

Does RTC and SD names work as of today? Proteus? Hellen?

We have a report https://rusefi.com/forum/viewtopic.php?f=19&t=2428

@rusefillc rusefillc added the bug label Sep 9, 2022
@rusefillc
Copy link
Contributor Author

rusefillc commented Sep 14, 2022

I've just seen proper SD card file names with date on hellen154h

@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

I've just seen proper SD card file names with date on hellen154h

are they correct?

ie,

  1. install battery, connect ECU to rusefi console so it sets time
  2. unplug ECU, leave on shelf unpowered for 24h
  3. power without USB so that it writes a log
  4. check timestamp, confirm it's right

@rusefillc
Copy link
Contributor Author

I love the test plan and have no time to try :(

@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

really? it takes 5 minutes twice, 24 hours apart

@mck1117 mck1117 reopened this Sep 14, 2022
@mck1117
Copy link
Member

mck1117 commented Sep 14, 2022

@BeerMoneyMotorsports since @rusefillc seems unable, can you give it a try on latest prerelease firmware?

@BeerMoneyMotorsports
Copy link
Contributor

I will try it tomorrow morning. I just updated an ecu that i fixed. Set timestamp and all. Ill run it in the lemon.

@BeerMoneyMotorsports
Copy link
Contributor

it does not maintain correct time. i just did a log and it still shows the time from when i connected console last night.

@mck1117
Copy link
Member

mck1117 commented Sep 15, 2022

so that's a no, it doesn't work

@mck1117
Copy link
Member

mck1117 commented Sep 20, 2022

#define STM32_LSE_ENABLED                   FALSE

seems like a smoking gun to me

@rusefillc
Copy link
Contributor Author

Actually

// todo: apply LSE patch

@rusefillc
Copy link
Contributor Author

#463 says 'hello 2022'

@mck1117
Copy link
Member

mck1117 commented Sep 20, 2022

well, we shouldn't technically need LSE for the rtc to do something

LSI will still work, if inaccurate. I believe hellen boards have an LSE, though.

@mck1117
Copy link
Member

mck1117 commented Sep 20, 2022

rtc survives soft reset (no power cycle) with LSI as-is, need to test with battery

@mck1117 mck1117 mentioned this issue Sep 20, 2022
@rusefillc
Copy link
Contributor Author

@nmschulte any interest to poke further? Any interest to restore LSE auto-detection see #463?

@nmschulte
Copy link
Contributor

nmschulte commented Jan 6, 2023

I haven't built or tested the changes for ChibiOS or rusEFI (no LSE hardware).

I added logic for all STM32 devices in ChibiOS, and re-enabled LSE for the three STM32 mcuconf.h (unsure which ones need/want it).

I didn't re-add the rtcWorks sentinel flag, figuring this can be checked via ChibiOS mechanisms i.e. (RCC->BDCR & RCC_BDCR_LSERDY) != 0 (depending specific STM32 variant).

Some take-aways:

  • firmware/docs/rusEFI_custom_chibios.md stands to be reviewed
    • linking to a list of commits w/ good messages would eliminate the need to maintain this file
  • firmware/docs/chibios_rusefi_20.patch needs updated
    • linking to commits/diffs (on GitHub) in rusefi/ChibiOS.git would eliminate the need to maintain these files
  • something I'm forgetting I'm sure ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants