Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we have wiki2-technical rusefi_documentation public #165

Closed
rusefillc opened this issue Oct 7, 2021 · 10 comments
Closed

Why do we have wiki2-technical rusefi_documentation public #165

rusefillc opened this issue Oct 7, 2021 · 10 comments

Comments

@rusefillc
Copy link
Contributor

Q1: does anyone remember if we need rusefi_documentation at all?

Q2: shall we make it private in order to reduce google search results mess?

@rusefillc
Copy link
Contributor Author

Depends on #166

@rusefillc rusefillc reopened this Oct 9, 2021
@rusefillc
Copy link
Contributor Author

@chuckwagoncomputing I've just made https://github.com/rusefi/rusefi_documentation/ public again because of

It seems that making rusefi/rusefi_documentation private has caused all forks to instead be forks of rusefillc/rusefi_documentation. Now I can't PR or compare to rusefi/rusefi_documentation, only rusefills/rusefi_documentation.

image

@chuckwagoncomputing
Copy link
Member

FWIW, having rusefi_documentation makes contributing to documentation via PR possible for people who aren't part of the documentation group.

@rusefillc
Copy link
Contributor Author

@chuckwagoncomputing huh? I believe that anyone can edit rusEFI wiki, at least the text part?

I am not sure how can people upload images via www to be honest.

@chuckwagoncomputing
Copy link
Member

Are you referring to the wiki at github.com/rusefi/rusefi/wiki or the wiki at https://rusefi.com/docs/wiki/Home/?
If you are referring to github.com/rusefi/rusefi/wiki, it is my understanding that only members of the rusEFI organization have write access.
With Wiki3 (https://rusefi.com/docs/wiki/Home), the documentation workflow is only through PR'ing rusefi_documentation. Each page has a button/link to edit on Github.

@rusefillc
Copy link
Contributor Author

i believe that anyone can edit github.com/rusefi/rusefi/wiki

image

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

so we have two questions

Q1: why do we need rusefi_documentation NOW, "before" wiki3

Q2: would rusefi_documentation be used for wiki3? technically we can have http://github.com/rusefi/rusefi/wiki be the source for wiki3 generation. I am not proposing I am only saying that I do not understand what is the best/only way for future workflow

@chuckwagoncomputing
Copy link
Member

Re: Q2:
I don't think you can add images in the Github Wiki interface, but I'm not positive about that.

@rusefillc
Copy link
Contributor Author

Closing @mck1117 @mi-hol @chuckwagoncomputing FYI.

@rusefillc rusefillc changed the title Why do we have rusefi_documentation public Why do we have wiki2-technical rusefi_documentation public Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants