Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix android crash on app lifecycle #97

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

jaumard
Copy link
Collaborator

@jaumard jaumard commented Feb 12, 2020

Basically I have this kind of crash CameraException(error, Attempt to invoke virtual method 'android.view.Surface android.media.ImageReader.getSurface()' on a null object reference) after searching a bit I found some related open bug in flutter repo with the temporary fix for this who is listen the app lifecycle and reset the controller. So I hope it will fix crashes.

Also:
fix #96
fix #88
fix #62
fix #74

@jaumard jaumard requested a review from Kleak February 12, 2020 13:05
expose camera controller
bump deps
Copy link
Contributor

@Kleak Kleak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaumard jaumard merged commit 03e4d02 into master Feb 12, 2020
@jaumard jaumard deleted the bugfix/crashCameraAndroid branch February 12, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants