Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has_known_suffix always return true #30

Closed
Diggsey opened this issue Apr 29, 2020 · 2 comments
Closed

has_known_suffix always return true #30

Diggsey opened this issue Apr 29, 2020 · 2 comments

Comments

@Diggsey
Copy link

Diggsey commented Apr 29, 2020

This is a security vulnerability, as programs may rely on this to screen out local domains, eg. "example.svc.local".

I understand that the algorithm described on https://publicsuffix.org/list/ specifies that:

If no rules match, the prevailing rule is "*".

However, this is for a specific use-case: when determining what part of the domain is the public suffix. Using this rule when determining whether the suffix is "known" is a huge security hole, as it essentially treats all domains as "known".

Specifically the "type" should be None, if the wildcard rule is used as a fallback.

@bradfier
Copy link
Contributor

bradfier commented Apr 30, 2020

#31 contains a possible minimal fix for this behaviour.

@rushmorem
Copy link
Owner

Fixed by #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants