remove Box in ListNode & 2018 edition

Cargo.toml

@@ -8,6 +8,7 @@ documentation = "https://docs.rs/publicsuffix"
 readme = "README.md"
 keywords = ["tld", "gtld", "cctld", "domain", "psl"]
 authors = ["rushmorem <rushmore@webenchanter.com>"]
+edition = "2018"
 
 [features]
 default = ["remote_list"]
@@ -18,11 +19,16 @@ error-chain = { version = "0.12", default-features = false }
 idna = "0.2"
 regex = { version = "1.0", default-features = false, features = ["std"] }
 url = "2.0"
-lazy_static = "1.0"
+lazy_static = "1.4"
 
 [dependencies.native-tls]
 version = "0.2"
 optional = true
 
-[dev_dependencies]
+[dev-dependencies]
+criterion = "0.3"
 rspec = "=1.0.0-beta.3"
+
+[[bench]]
+name = "bench"
+harness = false

benches/bench.rs

@@ -1,21 +1,17 @@
-#![feature(test)]
+use criterion::{black_box, criterion_group, criterion_main, Criterion};
 
-extern crate test;
-
-#[bench]
-fn bench_com(b: &mut test::Bencher) {
+fn criterion_benchmark(c: &mut Criterion) {
     let list = publicsuffix::List::fetch().unwrap();
-    b.iter(|| {
-        let res = list.parse_domain("raw.github.com").unwrap();
-        assert_eq!(res.suffix().unwrap(), "com");
+    c.bench_function("bench raw.github.com", |b| {
+        b.iter(|| list.parse_domain(black_box("raw.github.com")).unwrap())
     });
-}
-
-#[bench]
-fn bench_jp(b: &mut test::Bencher) {
-    let list = publicsuffix::List::fetch().unwrap();
-    b.iter(|| {
-        let res = list.parse_domain("www.city.yamanashi.yamanashi.jp").unwrap();
-        assert_eq!(res.suffix().unwrap(), "yamanashi.yamanashi.jp");
+    c.bench_function("bench www.city.yamanashi.yamanashi.jp", |b| {
+        b.iter(|| {
+            list.parse_domain(black_box("www.city.yamanashi.yamanashi.jp"))
+                .unwrap()
+        })
     });
 }
+
+criterion_group!(benches, criterion_benchmark);
+criterion_main!(benches);

src/errors.rs

@@ -1,4 +1,5 @@
-//! Errors returned by this library
+/// Errors returned by this library
+use error_chain::error_chain;
 
 #[cfg(feature = "remote_list")]
 use std::net::TcpStream;