Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hashbrown from 0.11.2 to 0.12.1 #36

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

jqnatividad
Copy link
Contributor

@jqnatividad jqnatividad commented Jun 17, 2022

First off @rushmorem , thanks for this crate!
Sending this small PR to bump hashbrown

@BlackDex
Copy link

It would be nice for this to be updated to the latest version.
A lot of other crates already have updated to this version.

The only thing which probably need to be done is bump the MSRV to 1.56 and some other changes?
@rushmorem is that something you would consider?

@rushmorem rushmorem merged commit a5d2dfc into rushmorem:main Aug 9, 2022
@rushmorem
Copy link
Owner

Thank you @jqnatividad. I'm sorry for the late response. I have been so tied up at work, I totally forgot about this PR.

@rushmorem
Copy link
Owner

v2.2.0 is now out. Heads up: I switched the hasher from our fork of fxhash to ahash, which is hashbrown's default. This change caused a performance regression as follows:-

With aHash:

test bench_domain ... bench:          42 ns/iter (+/- 19)
test bench_find   ... bench:          30 ns/iter (+/- 2)
test bench_suffix ... bench:          38 ns/iter (+/- 1)

With FxHash:

test bench_domain ... bench:          25 ns/iter (+/- 1)
test bench_find   ... bench:          17 ns/iter (+/- 0)
test bench_suffix ... bench:          17 ns/iter (+/- 1)

If such a regression is unacceptable for you, let me know.

@BlackDex
Copy link

BlackDex commented Aug 9, 2022

@rushmorem not sure it will have a huge impact.
The only impact i see in the changes you committed is the cargo upgrade, which now pins those versions to there patch level instead of there minor.

@rushmorem
Copy link
Owner

not sure it will have a huge impact

Awesome!

The only impact i see in the changes you committed is the cargo upgrade, which now pins those versions to there patch level instead of there minor.

Not necessarily. Cargo versions default to ^ rather than =. It will still accept newer non-breaking versions of those crates. To pin to a specific hashbrown dependency, for example, I would have to use =0.12.3 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants