Add simple API extension to parse domain names with invalid characters #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to address
#6
I tried to keep the API changes minimal, although I am not sure if the possibility to create
Domain
structs which are invalid is wanted, but it was the simplest way to implement it.The validating could be made a bit more strict, by extending
Domain::has_valid_syntax()
to have a flag which ignores the regexset but performs the rest of the validation.