Fix panic in Domain::assemble caused by having a single label with trailing dot #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailing dot Domain::find_match miscounts the labels as being 2, if there is a single label with a trailing dot causing an index out of range panic.
|
Looks good. Thank you :) |
It does. Would you like to tackle this as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Domain::find_match miscounts the labels as being 2, if there is a single
label with a trailing dot causing an index out of range panic.
Fixes #8
I just double checked that it still errors for double trailing dots. For everything parsed with
parse_domainthe check in line 668 catches it. Forparse_dns_nametheto_asciimethod errors with aTooShortForDns.It might make sense to replace the
?with achain_errand also convert it intoInvalidDomain, but thats a different issue.