Stop execution on unrecognized flags, support arg terminator (--)
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting files when the given args are invalid is risky behaviour; what if the user intended `-i` but typed `-j`? This commit improves compatibility with GNU rm.
Arguments appearing after the argument terminator (`--`) will now be treated as filenames. Note that the check for arguments beginning with `-` can be removed because the previous commit (bd304db) effectively moved that check to the argument-parser. This commit improves compatibility with GNU rm.
ninedotnine
changed the title
--)
rushsteve1
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting files when the given args are invalid is risky behaviour;
what if the user intended
-ibut typed-j?This commit improves compatibility with GNU rm.
closes #9
edit:
closes #8