Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice support on Windows and macOS #10

Open
ruslang02 opened this issue Sep 20, 2020 · 3 comments
Open

Voice support on Windows and macOS #10

ruslang02 opened this issue Sep 20, 2020 · 3 comments
Labels
enhancement New feature or request
Projects
1.0

Comments

@ruslang02
Copy link
Owner

ruslang02 commented Sep 20, 2020 •
edited

As of now, there is no support for voice channels in the client. Hopefully, it is possible to implement it.

Notes:
@ruslang02 ruslang02 added the enhancement New feature or request label Sep 22, 2020
ruslang02 pushed a commit that referenced this issue Oct 9, 2020
fix: add platform checks to pulseaudio2 library (#10)
22299a3 
chore(deps): remove zlib-sync due to issues on Win32
types(pulseaudio2): make Context non-default
@ruslang02
Copy link
Owner Author

Also 5f8645b, 73f8c23, 468e731

@ruslang02 ruslang02 changed the title Voice support Voice support on Windows and macOS Oct 12, 2020
@ruslang02 ruslang02 added this to To Do in 1.0 Oct 12, 2020
ruslang02 pushed a commit that referenced this issue Jan 5, 2021
feat(Voice): voice support for Windows and macOS
1b08596 
Refactored the entire voice subsystem, now with a generalized API.
Added ffplay-static to handle playback on Windows and macOS.
Added an option to specify additional ffmpeg args (filters etc.).
Linux requires installed ffmpeg, static does not include pulse support.
macOS compatibility not tested.

Partially resolves issue #10.
@ran-j
Copy link

ran-j commented Jan 11, 2021

why not use https://github.com/ran-j/mic6

@ruslang02
Copy link
Owner Author

@ran-j it uses ALSA recording solution which is pretty bad on Linux as it is application-exclusive and not controllable via PulseAudio. FFMPEG can do all the work for us so I guess we've settled on the library to use.

@Atrate Atrate mentioned this issue Mar 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
1.0
To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ran-j @ruslang02