Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add 'state_machine' package #1163

Merged
merged 4 commits into from Nov 10, 2017
Merged

Add 'state_machine' package #1163

merged 4 commits into from Nov 10, 2017

Conversation

NukeBird
Copy link
Contributor

@NukeBird NukeBird commented Nov 5, 2017

No description provided.

@NukeBird
Copy link
Contributor Author

NukeBird commented Nov 5, 2017

SphinxWarning: /home/travis/build/ruslo/hunter/docs/packages/all.rst:8:toctree contains reference to document u'packages/pkg/state_machine' that doesn't have a title: no link will be generated
Warning, treated as error:
/home/travis/build/ruslo/hunter/docs/packages/all.rst:8:toctree contains reference to document u'packages/pkg/state_machine' that doesn't have a title: no link will be generated

How can I fix this?

@dvirtz
Copy link
Contributor

dvirtz commented Nov 6, 2017 via email

@NukeBird
Copy link
Contributor Author

NukeBird commented Nov 6, 2017

@dvirtz thank you!

@NukeBird
Copy link
Contributor Author

NukeBird commented Nov 10, 2017

all tests passed except default toolchain on travis-ci

ingenue#157

@ruslo
Copy link
Owner

ruslo commented Nov 10, 2017

all tests passed except default toolchain on travis-ci

You can find instructions for remote CI testing and excluding tests here:

@NukeBird
Copy link
Contributor Author

@ruslo so... Must I exclude default test + make new pull request of pr.pkg.state_machine?

@ruslo
Copy link
Owner

ruslo commented Nov 10, 2017

Must I exclude default test + make new pull request of pr.pkg.state_machine?

Yes.

@@ -58,6 +58,7 @@ hunter_config(CppNetlib VERSION 0.10.1-hunter-3)
hunter_config(CppNetlibUri VERSION 1.0.4-hunter)
hunter_config(CsvParserCPlusPlus VERSION 1.0.1)
hunter_config(Eigen VERSION 3.3.4-p0)
hunter_config(state_machine VERSION 1.1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could we have alphabetical order, following the ASCII order, in default.cmake? (in doubt: http://www.asciitable.com/ )

There are some packages out of ascii order, although in alphabetical order, which already makes things incongruent, but placing libs completely random in the file like this hinders maintenance .

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pretyman it makes sense. Next time I will fix it, thanks

@ruslo ruslo merged commit 636f092 into ruslo:master Nov 10, 2017
@ruslo
Copy link
Owner

ruslo commented Nov 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants