Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

add re2 + test #1171

Merged
merged 3 commits into from Nov 10, 2017
Merged

add re2 + test #1171

merged 3 commits into from Nov 10, 2017

Conversation

headupinclouds
Copy link
Contributor

@headupinclouds headupinclouds commented Nov 7, 2017

@ruslo
Copy link
Owner

ruslo commented Nov 9, 2017

has hunter-packages/re2

Done: https://github.com/hunter-packages/re2

project(download-re2)

hunter_add_package(re2)
find_package(re2 CONFIG REQUIRED)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be find_package(RE2 CONFIG REQUIRED):

Could not find a package configuration file provided by "re2" with any of
the following names:

  re2Config.cmake
  re2-config.cmake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Done. Test: SUCCESS

@headupinclouds
Copy link
Contributor Author

headupinclouds commented Nov 10, 2017

  • Appveyor: All good!
  • Travis failures: default, analyze, android-ndk-r10e-api-19-armeabi-v7a-neon (incomplete c++11, which is a simple incompatibility)

@ruslo ruslo merged commit dd92722 into ruslo:master Nov 10, 2017
@ruslo
Copy link
Owner

ruslo commented Nov 11, 2017

@headupinclouds headupinclouds deleted the pr.re2 branch January 28, 2018 16:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants