Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Add ros_console_bridge package #1403

Merged
merged 4 commits into from Apr 15, 2018
Merged

Conversation

lsolanka
Copy link
Contributor

I've followed this guide step by step carefully, until section CI Testing, which instructs me to create several branches based on the package name.

I stopped there because I would first like to get feedback on package naming: The original repository is called console_bridge (https://github.com/ros/console_bridge) but I thought because this is part of ROS, each package could have ros- prepended to its name, i.e. in this case ros-console_bridge, to distinguish the set of ROS-related packages.

I'm not sure if that is desired so I thought I would first open the PR and then when the package names are clarified I would finish the CI build.

This PR is part of this "New package" request: #1397.

@ruslo
Copy link
Owner

ruslo commented Apr 15, 2018

The original repository is called console_bridge (https://github.com/ros/console_bridge) but I thought because this is part of ROS, each package could have ros- prepended to its name

Yes, I guess so. Actually it probably make sense to rename ros related forks. What do you think?

@lsolanka
Copy link
Contributor Author

Actually it probably make sense to rename ros related forks. What do you think?

Agree, that would make all naming consistent. I checked if I can do it but don't see the 'Settings' button on those forks so I guess I don't have permissions.

@ruslo
Copy link
Owner

ruslo commented Apr 15, 2018

Renamed.

I kept names for:

@lsolanka
Copy link
Contributor Author

https://github.com/hunter-packages/geometry2 (C++ namespace tf2 inside, should it be named tf2?)

Sounds good to me to rename. It contains only tf2_* and a geometry2 metapackage which other catkin packages cannot depend on anyway (catkin policy).

So the users would then do:

hunter_add_package(tf2)
find_package(catkin COMPONENTS tf2 tf2_ros) # or just find_package(tf2) if they prefer not to use catkin

https://github.com/hunter-packages/catkin

Sounds fine as well, users would then do:

hunter_add_package(catkin)
find_package(catkin COMPONENTS catkin_pkg1 catkin_pkg2)

which is more natural than hunter_add_package(ros_catkin) and then find_package(catkin)

Also if catkin and tf2 do not have a ros_ prefix, I would suggest to keep actionlib with the original name instead of ros_actionlib. This way, the usual set of packages required in 90% of situations would be:

hunter_add_package(catkin)
hunter_add_package(ros_comm)
hunter_add_package(actionlib)
hunter_add_package(tf2)

@lsolanka lsolanka changed the title Add ros-console_bridge package Add ros_console_bridge package Apr 15, 2018
@ruslo
Copy link
Owner

ruslo commented Apr 15, 2018

Repositories renamed, please check.

@lsolanka
Copy link
Contributor Author

Looks good.

@lsolanka
Copy link
Contributor Author

Finished ingenue#224 (testing), I think this is ready for review. I hope I didn't forget anything.

- `Hunterized <https://github.com/hunter-packages/ros_console_bridge>`__
- `Example <https://github.com/ruslo/hunter/blob/master/examples/ros_console_bridge/CMakeLists.txt>`__
- Added by
- `Lukas Solanka <https://github.com/lsolanka>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 1403 instead of N

@ruslo ruslo merged commit 2531d2e into ruslo:master Apr 15, 2018
@lsolanka lsolanka deleted the pr.ros-console_bridge branch April 15, 2018 19:23
@ruslo
Copy link
Owner

ruslo commented Apr 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants