Conversation
Yes, I guess so. Actually it probably make sense to rename ros related forks. What do you think? |
Agree, that would make all naming consistent. I checked if I can do it but don't see the 'Settings' button on those forks so I guess I don't have permissions. |
Renamed. I kept names for:
|
Sounds good to me to rename. It contains only tf2_* and a geometry2 metapackage which other catkin packages cannot depend on anyway (catkin policy). So the users would then do: hunter_add_package(tf2)
find_package(catkin COMPONENTS tf2 tf2_ros) # or just find_package(tf2) if they prefer not to use catkin Sounds fine as well, users would then do: hunter_add_package(catkin)
find_package(catkin COMPONENTS catkin_pkg1 catkin_pkg2) which is more natural than Also if catkin and tf2 do not have a hunter_add_package(catkin)
hunter_add_package(ros_comm)
hunter_add_package(actionlib)
hunter_add_package(tf2) |
ros-console_bridge
packageros_console_bridge
package
Repositories renamed, please check. |
Looks good. |
Finished ingenue#224 (testing), I think this is ready for review. I hope I didn't forget anything. |
- `Hunterized <https://github.com/hunter-packages/ros_console_bridge>`__ | ||
- `Example <https://github.com/ruslo/hunter/blob/master/examples/ros_console_bridge/CMakeLists.txt>`__ | ||
- Added by | ||
- `Lukas Solanka <https://github.com/lsolanka>`__ (`pr-N <https://github.com/ruslo/hunter/pull/N>`__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 1403
instead of N
I've followed this guide step by step carefully, until section CI Testing, which instructs me to create several branches based on the package name.
I stopped there because I would first like to get feedback on package naming: The original repository is called
console_bridge
(https://github.com/ros/console_bridge) but I thought because this is part of ROS, each package could haveros-
prepended to its name, i.e. in this caseros-console_bridge
, to distinguish the set of ROS-related packages.I'm not sure if that is desired so I thought I would first open the PR and then when the package names are clarified I would finish the CI build.
This PR is part of this "New package" request: #1397.