Add 'tcl' package #1515
Add 'tcl' package #1515
Conversation
cmake/find/Findtcl.cmake
Outdated
| if(NOT TCL_LIBRARY) | ||
| message(FATAL_ERROR "TCL_LIBRARY not found!") | ||
| endif() | ||
| add_library("tcl" UNKNOWN IMPORTED) |
There was a problem hiding this comment.
For imported libraries it's better to use tcl::tcl.
cmake/find/Findtcl.cmake
Outdated
| IMPORTED_LOCATION "${TCL_LIBRARY}" | ||
| IMPORTED_LINK_INTERFACE_LIBRARIES "${interface_libraries}" | ||
| ) | ||
| get_filename_component(TCL_LIB_DIR "${TCL_ORIG_LIBRARY}" DIRECTORY CACHE) |
| @@ -0,0 +1,333 @@ | |||
| # Copyright (c) 2015 Ruslan Baratov, Alexandre Pretyman | |||
There was a problem hiding this comment.
It's better to update original module instead of creating new and maintaining duplicate.
There was a problem hiding this comment.
cmake/modules/hunter_autotools_project.cmake updated
| EXTRA_FLAGS | ||
| ${extra_flags} | ||
| PATCH_COMMAND | ||
| ${patch_command} |
There was a problem hiding this comment.
Please clean up trailing whitespaces:
| list(APPEND cflags "--include android_def.h") | ||
| list(APPEND extra_flags "--enable-langinfo=no") | ||
| list(APPEND patch_command | ||
| && ${CMAKE_COMMAND} -E copy "@HUNTER_PACKAGE_SCRIPT_DIR@/android_def.h" "@HUNTER_PACKAGE_SOURCE_DIR@" |
There was a problem hiding this comment.
Please try not to use &&:
You can extend ExternalProject_Add step by COMMAND, I think it should work here.
There was a problem hiding this comment.
substituted && by COMMAND
build ok https://travis-ci.com/drodin/hunter/builds/81224211
| @@ -0,0 +1,41 @@ | |||
| find_path( | |||
There was a problem hiding this comment.
If we are using pkgconfig-export-targets.cmake.in (see below) then this module is not needed, package can be imported by PkgConfig::tcl, see example:
There was a problem hiding this comment.
tried it, and it's not working for this project at least without a complete rewrite of tcl.pc
There was a problem hiding this comment.
it's not working for this project
What are the errors? May be hunter_pkgconfig_export_target need to be improved?
There was a problem hiding this comment.
Here is a tcl.pc file after running ./configure on a Mac, building static lib
# tcl pkg-config source file
prefix=/Users/user/workspace/mobile/hunter/_Base/xxxxxxx/2dec4d1/c0825ff/Build/tcl/Install
exec_prefix=/Users/user/workspace/mobile/hunter/_Base/xxxxxxx/2dec4d1/c0825ff/Build/tcl/Install
libdir=/Users/user/workspace/mobile/hunter/_Base/xxxxxxx/2dec4d1/c0825ff/Build/tcl/Install/lib
includedir=${prefix}/include
Name: Tool Command Language
Description: Tcl is a powerful, easy-to-learn dynamic programming language, suitable for a wide range of uses.
URL: http://www.tcl.tk/
Version: 8.6.8
Requires.private: zlib >= 1.2.3
Libs: -L${libdir} -ltcl8.6 -ltclstub8.6
Libs.private: -lz -lpthread
Cflags: -I${includedir}
-
Requires.private: zlib >= 1.2.3if I don't add package zlib, I get error -- Package 'zlib', required by 'tcl', not found otherwise Target "tcl_test" links to target "PkgConfig::zlib" but the target was not found. But there is really no need for hunter zlib, as configure tests for system zlib and if not found can use one provided with the package. -
Dependencies are not in Libs: thet are in Libs.private: so they are not included in _LDFLAGS or INTERFACE_LINK_LIBRARIES
-
There is no dependency on the libm, that breaks testing on Linux
There was a problem hiding this comment.
But there is really no need for hunter zlib, as configure tests for system zlib and if not found can use one provided with the package
It should be always zlib from Hunter:
- https://docs.hunter.sh/en/latest/creating-new/create/cmake-dependencies.html#conflict
- https://docs.hunter.sh/en/latest/faq/interaction-with-other-package-managers.html
Target "tcl_test" links to target "PkgConfig::zlib" but the target was not found
I think this part is already handled quite well for autotools, take a look at DEPENDS_ON_PACKAGES variable, e.g.:
hunter/cmake/projects/x11/hunter.cmake
Lines 26 to 40 in 2964970
Dependencies are not in Libs: thet are in Libs.private
I don't know the details but I guess private libraries should not be used anywhere, if you got linker errors related to such libraries then they are not private - tcl.pc issue.
There is no dependency on the libm, that breaks testing on Linux
Yes, that's a tcl.pc issue too.
| @@ -0,0 +1,3 @@ | |||
| #if __ANDROID_API__ < 21 | |||
| #undef HAVE_STRUCT_DIRENT64 | |||
| #endif | |||
There was a problem hiding this comment.
| @@ -0,0 +1,41 @@ | |||
| find_path( | |||
There was a problem hiding this comment.
it's not working for this project
What are the errors? May be hunter_pkgconfig_export_target need to be improved?
I've followed this guide
step by step carefully. Yes
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
I have submitted CI configs to https://github.com/ingenue/hunter targeting
pkg.templatebranch,see this merged pull request Pr.pkg.tcl ingenue/hunter#274