Add "qhull" package #1596
Add "qhull" package #1596
Conversation
examples/qhull/CMakeLists.txt
Outdated
| find_package(qhull CONFIG REQUIRED) | ||
|
|
||
| add_executable(boo boo.cpp) | ||
| #target_link_libraries(boo qhull::libqhull) |
There was a problem hiding this comment.
Could you give me some advice on how to test bin files?
There was a problem hiding this comment.
test bin files
What bin files you want to test and how?
Hunter CI testing is only for building example, not running (at least at this moment). For local tesitng see:
There was a problem hiding this comment.
like, for example project build some bin files and i want to test it
docs/packages/pkg/qhull.rst
Outdated
| .. _pkg.qhull: | ||
|
|
||
| qhull | ||
| === |
docs/packages/pkg/qhull.rst
Outdated
|
|
||
| - `Official <https://github.com/qhull/qhull>`__ | ||
| - `Hunterized <https://github.com/t0p4/qhull>`__ | ||
| - `Example <https://github.com/t0p4/qhull/blob/hunter-7.2.0/CMakeLists.txt>`__ |
There was a problem hiding this comment.
Please use link to Hunter repository.
cmake/projects/qhull/hunter.cmake
Outdated
| VERSION | ||
| 7.2.0-p0 | ||
| URL | ||
| "https://github.com/t0p4/qhull/archive/v7.2.0-p0.tar.gz" |
There was a problem hiding this comment.
I've created https://github.com/hunter-packages/qhull and branch hunter-7.2.0. Please send patches there, see:
docs/packages/pkg/qhull.rst
Outdated
| - `Official <https://github.com/qhull/qhull>`__ | ||
| - `Hunterized <https://github.com/t0p4/qhull>`__ | ||
| - `Example <https://github.com/t0p4/qhull/blob/hunter-7.2.0/CMakeLists.txt>`__ | ||
| - Added by `qhull_developer <https://github.com/t0p4>`__ (`pr-N <https://github.com/ruslo/hunter/pull/1596>`__) |
examples/qhull/boo.cpp
Outdated
| @@ -0,0 +1,4 @@ | |||
| #include <string.h> | |||
There was a problem hiding this comment.
We are not testing anything here, please add at least some header from package.
docs/packages/pkg/qhull.rst
Outdated
|
|
||
| - `Official <https://github.com/qhull/qhull>`__ | ||
| - `Hunterized <https://github.com/hunter-packages/qhull>`__ | ||
| - `Example <https://github.com/hunter-packages/qhull/blob/hunter-7.2.0/CMakeLists.txt>`__ |
There was a problem hiding this comment.
No, it should be https://github.com/ruslo/hunter/blob/master/examples/qhull/CMakeLists.txt, see template file:
And documentation:
docs/packages/pkg/qhull.rst
Outdated
| - `Example <https://github.com/ruslo/hunter/blob/master/examples/qhull/CMakeLists.txt>`__ | ||
| - Added by `qhull_developer <https://github.com/t0p4>`__ (`pr-1596 <https://github.com/ruslo/hunter/pull/1596>`__) | ||
|
|
||
| .. code-block:: cmake |
There was a problem hiding this comment.
Please use code from example, see template:
examples/qhull/CMakeLists.txt
Outdated
| find_package(qhull CONFIG REQUIRED) | ||
|
|
||
| add_executable(boo boo.cpp) | ||
| #target_link_libraries(boo qhull::libqhull) |
There was a problem hiding this comment.
test bin files
What bin files you want to test and how?
Hunter CI testing is only for building example, not running (at least at this moment). For local tesitng see:
examples/qhull/boo.cpp
Outdated
| @@ -0,0 +1,4 @@ | |||
| #include <libqhull.h> | |||
There was a problem hiding this comment.
Not working:
examples/qhull/boo.cpp:1:22: fatal error: libqhull.h: No such file or directory
There was a problem hiding this comment.
It's work, it can't find path. I need your advice to make it correct
There was a problem hiding this comment.
I need your advice to make it correct
Advice about what?
I've followed this guide
step by step carefully. [Yes]
I've tested this package remotely and have excluded all broken builds.
Here is the links to the Travis/AppVeyor with status "All passed":
I have submitted CI configs to https://github.com/ingenue/hunter targeting
pkg.templatebranch,see this merged pull request Test 'qhull' package ingenue/hunter#282