Add the GoogleTest package to hunter.

[Knitschi]

The changes add the GoogleTest hunter package to hunter.

The package can be used with:

# file CMakeLists.txt

hunter_add_package(GoogleTest)
find_package(gtest CONFIG REQUIRED)  # when only gtest is needed
find_package(gmock CONFIG REQUIRED)  # when gmock and gtest is needed
...
# link libraries as needed
target_link_libraries( 
  MyExe PUBLIC 
  gtest::gtest 
  gtest::gtest_main 
  gmock::gmock 
  gmock::gmock_main 
) 

[ruslo]

The package can be used with

I think interface should not change and package should be called GTest. See my note:

• Added config file mode support for cmake find_package() hunter-packages/googletest#1 (comment)

[Knitschi]

Oh damn I just read the you wanted me to change the name to GTest. I will do this first.

[ruslo]

Oh damn I just read the you wanted me to change the name to GTest. I will do this first.

Cool, thank you

[ruslo]

@Knitschi Also we need to apply some patches (will do it after your pull request) from GTest since it fixes different build bugs: https://github.com/hunter-packages/gtest/commits?author=ruslo. I remember that Windows build is tricky, some version works for Visual Studio and doesn't work for MinGW, updated version works for MinGW but doesn't work for Visual Studio...

hunter/cmake/configs/default.cmake

Line 103 in 0423182

if(MINGW)

[Knitschi]

Should I replace the old GTest project with the new GoogleTest project or leave it as it is?

[ruslo]

Should I replace the old GTest project with the new GoogleTest project or leave it as it is?

I'm not sure about it, I think yes. Also probably it make sense to add this version to existent GTest/hunter.cmake.

[Knitschi]

How do you test the builds for package on various platforms. Can the build server do that or does it only run the buildchains that are available on osx?

I am not sure how I can test the build for vs 2008 as I don't have a license for that version.

[ruslo]

How do you test the builds for package on various platforms

Same script for all toolchains: https://github.com/ruslo/hunter/wiki/dev.hunter.root#jenkinspy
Also note that GTest build failed for me without using Hunter at all.

Can the build server do that or does it only run the buildchains that are available on osx?

Yes for now, but few improvements are possible: https://github.com/ruslo/hunter/issues/180

I don't have a license for that version

I think there are free versions available: http://programmers.stackexchange.com/a/105159/116664 should be quite enough.

[ruslo]

Can the build server do that or does it only run the buildchains that are available on osx?

Unfortunately AppVeyor doesn't have 2005 studio: http://www.appveyor.com/docs/installed-software#visual-studio-2008. So there is no easy way to test vs-8-2005 toolchain automatically (unless somebody want to start custom jenkins server).

[Knitschi]

Update! The new version does not support MinGW and MSVC80. It also uses the newer release of the googletest package.

[ruslo]

hunter-packages/googletest#3 (comment)

[Knitschi]

Do you know what went wrong with the build? To me it looks like it has nothing to do with googletest.

[ruslo]

@Knitschi re:{Do you know what went wrong with the build} see hunter-packages/googletest#5

[ruslo]

@Knitschi Hi, I see you've updated this pull request. Just for your information I'm not receiving updates about such events :) http://0.readthedocs.org/en/latest/git.html#notify

[ruslo]

@Knitschi I've updated testing procedure. CI for this pull request:

• Windows: https://ci.appveyor.com/project/ingenue/hunter/build/1.0.40
• Linux/OSX: https://travis-ci.org/ingenue/hunter/builds/105851401

[Knitschi]

So the GTest builds started by travis have worked, right? But what does the blue bar mean for the AppVeyor builds?

[ruslo]

So the GTest builds started by travis have worked, right?

Just an example from Hunter, not testing from GTest repository (it's not the goal).

But what does the blue bar mean for the AppVeyor builds?

Waiting. I've created a lot of branches: https://github.com/ingenue/hunter/branches/all?page=1

[ruslo]

All tests passed, merging.

@Knitschi great job, thank you!

[ruslo]

Released: https://github.com/ruslo/hunter/releases/tag/v0.12.42

[Knitschi]

You are welcome. And thanks for the support. When I need another dependency for my code-base I will add it to hunter too.