Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Added Expat XML parser. #59

Merged
merged 1 commit into from Apr 7, 2015
Merged

Added Expat XML parser. #59

merged 1 commit into from Apr 7, 2015

Conversation

alamaison
Copy link
Contributor

http://expat.sourceforge.net/

Usage:

hunter_add_package(EXPAT)

find_package(Expat REQUIRED)

add_executable(foo foo.c)
target_compile_definitions(foo PRIVATE XML_STATIC)
target_link_libraries(foo PRIVATE ${EXPAT_LIBRARIES})
target_include_directories(foo PRIVATE ${EXPAT_INCLUDE_DIRS})

# * https://github.com/hunter-packages/gate
include("../common.cmake")

hunter_add_package(EXPAT)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it must be 'hunter_add_package(Expat)' here. Probably on OS like Mac or Windows it doesn't matter but on case sensitive platforms like Linux it will be an error.

http://expat.sourceforge.net/

Usage:
hunter_add_package(Expat)

find_package(EXPAT REQUIRED)

add_executable(foo foo.c)
target_compile_definitions(foo PRIVATE XML_STATIC)
target_link_libraries(foo PRIVATE ${EXPAT_LIBRARIES})
target_include_directories(foo PRIVATE ${EXPAT_INCLUDE_DIRS})
@alamaison
Copy link
Contributor Author

Thanks. Fixed.

ruslo added a commit that referenced this pull request Apr 7, 2015
@ruslo ruslo merged commit e882a7e into ruslo:develop Apr 7, 2015
@alamaison alamaison deleted the expat branch April 8, 2015 00:21
@ruslo
Copy link
Owner

ruslo commented Nov 26, 2015

@alamaison Hi, Alex! I've fixed some issues with applying toolchain flags to C project (see details). Now some CI testing start failing at analyze toolchain (issue was that wrapper for clang analyzer was not used for C code but only for C++ code).

See Expat errors: https://travis-ci.org/ruslo/hunter/jobs/93227575#L606

I will disable it for now. Let me know if you want to fix it - I will enable it back after update.

Thanks, Ruslo

@alamaison
Copy link
Contributor Author

Let me know if you want to fix it - I will enable it back after update.

Sorry @ruslo, I've not had much free time lately. Will look at this if I get a chance, but it might not be soon :( Looks like issues in the upstream projects.

rahulshethsc pushed a commit to rbsheth/hunter that referenced this pull request Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants