Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Fix some unicode issues with logging #140

Closed
wants to merge 1 commit into from
Closed

Conversation

jcftang
Copy link

@jcftang jcftang commented May 3, 2017

I was seeing hanging behaviour. When I have this patch my builds succeed.

@ruslo
Copy link
Owner

ruslo commented May 3, 2017

I've seen some problems with encoding before but it was error from Python, not hanging:

I'm not sure I understand all parts, can you please explain in details what is happening? I guess leaving comments with link to documentation would be nice.

@jcftang
Copy link
Author

jcftang commented May 3, 2017

My build process generates output which causes this to occur...

Exception in thread Thread-6:
Traceback (most recent call last):
  File "/usr/lib64/python3.4/threading.py", line 911, in _bootstrap_inner
    self.run()
  File "/usr/lib64/python3.4/threading.py", line 859, in run
    self._target(*self._args, **self._kwargs)
  File "/home/build/polly/bin/detail/call.py", line 41, in fanout
    log_file.write(s)
UnicodeEncodeError: 'ascii' codec can't encode character '\xf6' in position 75: ordinal not in range(128)

AFAIK the build process for the project that I am working has many different languages which get emitted by whatever compiler/preprocessor that I am using. This output causes a crash in one of the threads that polly.py spawns and it then causes the script to just wait and never succeed.

@ruslo
Copy link
Owner

ruslo commented May 3, 2017

Please try fix from #141

@ruslo ruslo closed this May 4, 2017
@jcftang
Copy link
Author

jcftang commented May 4, 2017

FYI the patch looks good to me, will test later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants