Merge pull request #1519 from sepiropht/clippy-fixes

some clippy fxing
rusoto · Oct 4, 2019 · 9cd6d57 · 9cd6d57
2 parents 8ebae02 + b060a9b
commit 9cd6d57
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/service_crategen/src/botocore.rs b/service_crategen/src/botocore.rs
@@ -320,7 +320,7 @@ impl<'a> Operation {
         &self
             .input
             .as_ref()
-            .expect(&format!("Operation input undefined for {}", self.name))
+            .unwrap_or_else(|| panic!("Operation input undefined for {}", self.name))
             .shape
     }
 

diff --git a/service_crategen/src/commands/generate/codegen/mod.rs b/service_crategen/src/commands/generate/codegen/mod.rs
@@ -347,7 +347,7 @@ fn find_shapes_to_generate(service: &Service<'_>) -> BTreeSet<String> {
             }
         }
     }
-    return shapes_to_generate;
+    shapes_to_generate
 }
 
 fn generate_types<P>(

diff --git a/service_crategen/src/commands/generate/codegen/rest_xml.rs b/service_crategen/src/commands/generate/codegen/rest_xml.rs
@@ -160,7 +160,6 @@ fn generate_documentation(operation: &Operation, service: &Service<'_>) -> Strin
             if operation.name == "ChangeResourceRecordSets" {
                 docs = format!("/// For TXT records, see <a href=\"./util/fn.quote_txt_record.html\">util::quote_txt_record</a>\n{}", docs);
             }
-            ()
         }
         _ => (),
     }