Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S3 capability #18

Closed
matthewkmayer opened this issue Aug 14, 2015 · 7 comments
Closed

Add S3 capability #18

matthewkmayer opened this issue Aug 14, 2015 · 7 comments
Assignees

Comments

@matthewkmayer
Copy link
Member

Add functionality for S3. There's a branch for this already (https://github.com/DualSpark/rust-aws/tree/feature-s3) but after #17 it may be best to dump it and start over. This is due to refactoring of code generation and ability to do TDD for generated code instead of doing integration testing with AWS.

(Edit for book keeping on progress)
The AWS CLI offers these functions (http://docs.aws.amazon.com/cli/latest/reference/s3api/index.html):

abort-multipart-upload ✔️
complete-multipart-upload ✔️
copy-object
create-bucket ✔️
create-multipart-upload ✔️
delete-bucket ✔️
delete-bucket-cors
delete-bucket-lifecycle
delete-bucket-policy
delete-bucket-replication
delete-bucket-tagging
delete-bucket-website
delete-object ✔️
delete-objects
get-bucket-acl
get-bucket-cors
get-bucket-lifecycle
get-bucket-location
get-bucket-logging
get-bucket-notification
get-bucket-notification-configuration
get-bucket-policy
get-bucket-replication
get-bucket-request-payment
get-bucket-tagging
get-bucket-versioning
get-bucket-website
get-object ✔️
get-object-acl
get-object-torrent
head-bucket
head-object
list-buckets ✔️
list-multipart-uploads ✔️
list-object-versions
list-objects
list-parts ✔️
put-bucket-acl
put-bucket-cors
put-bucket-lifecycle
put-bucket-logging
put-bucket-notification
put-bucket-notification-configuration
put-bucket-policy
put-bucket-replication
put-bucket-request-payment
put-bucket-tagging
put-bucket-versioning
put-bucket-website
put-object ✔️
put-object-acl
restore-object
upload-part ✔️
upload-part-copy
wait

@thijsc
Copy link

thijsc commented Aug 16, 2015

S3 support would be awesome :-). Anything I could to to help this get done?

@matthewkmayer
Copy link
Member Author

Thanks for the support, I plan on tackling the basics in the next day or two. If I get hung up I'll update this issue.

@matthewkmayer
Copy link
Member Author

This is quite the ambitious ticket. We'll make smaller tickets for various S3 functionality and close this when we're all set.

@matthewkmayer
Copy link
Member Author

Part of this should be removing the allow dead code flag that's currently enabled due to the current state of S3 code. See #253 .

@ammojamo
Copy link

I have a need for the head-object operation and would be happy to have a go at implementing it. Is this something I can contribute or is the codebase in too much of a state of flux right now?

Disclaimer: I am very new to Rust.

@adimarco
Copy link
Member

I spent the weekend writing some codegen for the rest-xml protocol, and I'm using S3 as the test case. With a tiny change, I just got head_object() to work after seeing your comment. Give me a day or two to finish mopping up the mess I made, and I'll push the whole branch out to github with that working for you.

Not to discourage contribution, we'd love all of it that we can get. I just happen to be finishing up rewriting that exact bit 😄

@adimarco
Copy link
Member

Closing in favor of #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants