Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature refactor xmlstack #17

Merged
merged 16 commits into from
Aug 14, 2015
Merged

Feature refactor xmlstack #17

merged 16 commits into from
Aug 14, 2015

Conversation

matthewkmayer
Copy link
Member

Once complete this should fix #16 .

@matthewkmayer matthewkmayer mentioned this pull request Aug 14, 2015
@@ -158,6 +158,13 @@ impl SignedRequest {
// execute the damn request already
let client = Client::new();
let result = client.request(hyper_method, &final_uri).headers(hyper_headers).body(&payload).send().unwrap();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some kind of proper logging framework for Rust must exist by now. We should look into that.

adimarco added a commit that referenced this pull request Aug 14, 2015
@adimarco adimarco merged commit 1268cbe into master Aug 14, 2015
@matthewkmayer matthewkmayer deleted the feature-refactor-xmlstack branch August 14, 2015 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xmlutils are currently un-unit-testable
2 participants