Reduce the amount of code generated and avoid some allocations #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
June 15, 2020 15:06
iliana
approved these changes
Jul 14, 2020
iliana
added
the
waiting for rollup 🧶🏃♀️💨
iliana
added a commit
to iliana/rusoto
that referenced
this pull request
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rusoto takes quite a while to compile so I figured I would take a stab at improving the generated code. This mainly extracts common code into utility functions that can be reused but there are also a few alterations to avoid allocations in a few places.
See individual commits for changes.
https://github.com/rusoto/rusoto/pull/1773/files/d2eb42df67c20a9a883bac5c75ed4d8777d5c398 changes without the generated code changing.