Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leakless triggering false positive on Windows #260

Closed
rusq opened this issue Jan 4, 2024 · 1 comment · Fixed by #261
Closed

Leakless triggering false positive on Windows #260

rusq opened this issue Jan 4, 2024 · 1 comment · Fixed by #261

Comments

@rusq
Copy link
Owner

rusq commented Jan 4, 2024

Describe the bug
During the EZ-Login, Windows malware protection gets triggered.

Similar to BigJk/snd#28

BigJk mentions:

I dug a bit and leakless is a utility (https://github.com/ysmood/leakless) to "Run sub-process and make sure to kill it when the parent process exits.". It is used by https://github.com/go-rod/rod which S&D uses to control a chrome instance to create images from HTML. It's probably used to make sure that all sub-processes are killed correctly if rod shuts down.

To Reproduce

  1. Download` v2.5.0
  2. Run on windows

Expected behavior
Windows malware does not get triggered.

Output
image

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • Slackdump Version: 2.5.0

Additional context
Add any other context about the problem here.

@rusq
Copy link
Owner Author

rusq commented Jan 4, 2024

Solution: go-rod/rod#739 (comment)

@rusq rusq closed this as completed in #261 Jan 5, 2024
rusq added a commit that referenced this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant