Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved rate limiting #13

Merged
merged 9 commits into from
Jan 22, 2022
Merged

Improved rate limiting #13

merged 9 commits into from
Jan 22, 2022

Conversation

rusq
Copy link
Owner

@rusq rusq commented Jan 22, 2022

Fixes #12

  • Separate limiters for files, conversation and threads, and retries on 429 for all of those methods.
  • Generic withRetry function that retries upon receiving slack.RateLimitedError, waiting the RetriedAfter duration;

Minor:

  • switch to dlog library for logging
  • Introduce ability to trace the execution using runtime/trace
  • build version
  • allow the secrets to be stored in .env, or .env.txt or secrets.txt for convenience of notepad users.

@@ -1,233 +1,277 @@
package slackdump
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what happened here looks like it was brutally reformatted, so that it's own mother does not recognise it.

@rusq rusq changed the title Rate limiting for files download Improved rate limiting Jan 22, 2022
@rusq rusq merged commit 29d2bd5 into master Jan 22, 2022
@rusq rusq deleted the rate-limit branch January 22, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hitting 429 on a large channel with files
1 participant