Use system format for subscription price display #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hengyu
commented
May 5, 2024
| } | ||
|
|
||
| /// The price text for display (e.g. "$0.99 / 1 month", "$1.99 / 2 months"). | ||
| public var displayPrice: String { |
There was a problem hiding this comment.
Use Apple's recommended API for price display. The API can handle localization as well as singluar and plural units.
There was a problem hiding this comment.
Very good idea. This wasn't available when I first wrote the code so I had to create my display logic. Much better to use Apple's that supports proper localization.
Hengyu
commented
May 5, 2024
| @@ -56,21 +85,18 @@ public struct PrePurchaseSubscriptionInfo: Hashable { | |||
| /// single element with the promo id (which will be nil) and price/period for the offer. | |||
| /// - If there are no offers, the value of this property will be an array with a single element with the standard price/period. | |||
| public var purchasePriceForDisplay: [PurchasePriceForDisplay]? { | |||
| if promotionalOffersEligible, let promotionalOffers, promotionalOffers.count > 0 { | |||
| if promotionalOffersEligible, !promotionalOffers.isEmpty { | |||
There was a problem hiding this comment.
Using isEmpty is better than using count to tell if an array has elements
There was a problem hiding this comment.
I checked and yes you're correct! Apple recommend using isEmpty!
Hengyu
commented
May 5, 2024
| case .payUpFront: return "Pay up front" | ||
| default: return "Unknown" | ||
| if #available(iOS 15.4, macOS 12.3, tvOS 15.4, watchOS 8.5, visionOS 1.0, *) { | ||
| mode.localizedDescription |
There was a problem hiding this comment.
use Apple's API to support for localization
|
@russell-archer PTAL |
|
Really excellent PR! Thank you Hengyu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
Product.SubscriptionPeriod'sformattedmethod to display price.https://developer.apple.com/documentation/storekit/product/subscriptionperiod/4044346-formatted
This PR also simplifies code structure/