Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Product Codes not handled properly #268

Closed
1 task done
Trenly opened this issue Aug 3, 2023 · 1 comment
Closed
1 task done

[Bug]: Product Codes not handled properly #268

Trenly opened this issue Aug 3, 2023 · 1 comment
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Trenly
Copy link

Trenly commented Aug 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Take a look - https://github.com/microsoft/winget-pkgs/pull/115152/files

@Trenly Trenly added bug Something isn't working help wanted Extra attention is needed labels Aug 3, 2023
@russellbanks
Copy link
Owner

Hey, this happens because Komac had an issue (#200) where names that had an architecture word in them were identified as architectures:

https://www.website.com/ArmCord.exe -> arm

Because of this Komac looks for a delimiter before and after architectures to be certain about it:

https://www.website.com/ArmCord-x86.exe -> x86

The URLs from that pull request don't have delimiters surrounding them, so it resorts to the architecture value in the MSI, which is Intel.

I'll adjust the function that identifies architectures from URLs to cover this case by considering it being at the end of the URL and followed by .[extension].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants