Add fallback if cert is not in signatureElement #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, thanks. I'm going to merge this as-is, but one thought: if there is more than one cert in the store do you think it makes sense to try all of them? In order to support certificate rotation I think you'd eventually want to be able to have more than one. |
|
Good point with the certificate rotation. I think we should modify |
joicemjoseph
pushed a commit
to joicemjoseph/goxmldsig
that referenced
this pull request
Apr 13, 2020
Add fallback if cert is not in signatureElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.