Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event handlers + prometheus to the cli #54

Closed
wants to merge 15 commits into from
Closed

Conversation

russelltg
Copy link
Owner

No description provided.

@russelltg russelltg marked this pull request as draft July 4, 2020 16:13
@russelltg russelltg marked this pull request as ready for review August 8, 2020 18:09
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #54 (d282d53) into master (12cc266) will increase coverage by 2.15%.
The diff coverage is 82.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   78.01%   80.17%   +2.15%     
==========================================
  Files          36       37       +1     
  Lines        3279     2925     -354     
==========================================
- Hits         2558     2345     -213     
+ Misses        721      580     -141     
Impacted Files Coverage Δ
srt-protocol/src/protocol/receiver/buffer.rs 68.29% <35.48%> (-2.87%) ⬇️
srt-tokio/src/tokio/socket.rs 78.81% <93.10%> (-1.62%) ⬇️
srt-protocol/src/protocol/sender/buffers.rs 86.36% <94.11%> (+1.36%) ⬆️
srt-protocol/src/event.rs 100.00% <100.00%> (ø)
srt-protocol/src/protocol/mod.rs 88.37% <100.00%> (+0.42%) ⬆️
srt-protocol/src/protocol/receiver/mod.rs 83.76% <100.00%> (-3.63%) ⬇️
...protocol/src/protocol/sender/congestion_control.rs 92.15% <100.00%> (ø)
srt-protocol/src/protocol/sender/mod.rs 85.47% <100.00%> (-3.75%) ⬇️
srt-tokio/src/builder.rs 95.34% <100.00%> (+3.34%) ⬆️
srt-protocol/src/packet.rs 73.33% <0.00%> (-10.00%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12cc266...b10701e. Read the comment docs.

@russelltg russelltg mentioned this pull request Jan 18, 2021
@robertream
Copy link
Collaborator

This is way out of date, plus I'd like to discuss taking an approach for metrics that is closer to what both of the prominent QUIC rust libraries do for metrics: metrics scraping via a bare stats struct. We should least do this with the API for the tokio library. We could end up with an event driven interface for protocol, DuplexConnection in particular, but I'd like to work from the outside in, and creep up on an event driven approach via refactoring. I'd like to bubble events up to the tokio API (e.g. connection errors, key rotations, etc.) but this is a secondary concern, a nice to have. I'd like to just get a few basic metrics implemented first. Just a simple packet tx/rx count would be fine, to start with.

@russelltg
Copy link
Owner Author

Yeah, this branch is definitely too stable to be useful, and I think that sounds great--stats is definitely a huge missing feature right now.

@russelltg russelltg closed this Oct 26, 2021
@russelltg russelltg deleted the events branch December 23, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants