-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event handlers + prometheus to the cli #54
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 78.01% 80.17% +2.15%
==========================================
Files 36 37 +1
Lines 3279 2925 -354
==========================================
- Hits 2558 2345 -213
+ Misses 721 580 -141
Continue to review full report at Codecov.
|
This is way out of date, plus I'd like to discuss taking an approach for metrics that is closer to what both of the prominent QUIC rust libraries do for metrics: metrics scraping via a bare stats struct. We should least do this with the API for the tokio library. We could end up with an event driven interface for protocol, DuplexConnection in particular, but I'd like to work from the outside in, and creep up on an event driven approach via refactoring. I'd like to bubble events up to the tokio API (e.g. connection errors, key rotations, etc.) but this is a secondary concern, a nice to have. I'd like to just get a few basic metrics implemented first. Just a simple packet tx/rx count would be fine, to start with. |
Yeah, this branch is definitely too stable to be useful, and I think that sounds great--stats is definitely a huge missing feature right now. |
No description provided.