Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiplatform DataStore version 1.1.0-alpha05 #130

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

russhwolf
Copy link
Owner

Looks like no code changes needed to make this work other than moving source-sets. Creating a DataStore<Preferences> looks different in KMP than it did in JVM, but that's the responsibility of client code.

Relatedly, tests need to change more than code does. Configuring tests is ugly due to https://issuetracker.google.com/issues/251601628.

I have this branch passing locally on all host platforms but CI is failing some tests and I'm not sure why.

Let me know if you're interested in having this in a published release. I'm not a huge fan of releasing against a dev version of datastore but not wholly opposed to it if it makes it easier for people to try things out. But don't expect that to leave experimental status until there's a stable datastore to link against.

@russhwolf russhwolf changed the title Use multiplatform DataStore version 1.1.0-dev01 Use multiplatform DataStore version 1.1.0-alpha03 Mar 24, 2023
@russhwolf
Copy link
Owner Author

Updated to use datastore 1.1.0-alpha03. Now that DataStore is publishing multiplatform targets as part of the standard releases (though still calling them experimental), I'll probably aim to get this released when 1.1.0 goes stable. Let me know if you'd like to get it sooner.

Test config is much nicer now.

There are still failing tests in CI that I haven't been able to reproduce locally, but they're different tests then previously. Still not sure what's going on there.

@russhwolf russhwolf changed the title Use multiplatform DataStore version 1.1.0-alpha03 Use multiplatform DataStore version 1.1.0-alpha05 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant