Version 1.1 #167
Merged
Version 1.1 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russhwolf
commented
Aug 20, 2023
| @@ -91,11 +96,16 @@ import platform.darwin.OSStatus | |||
| * every key, if the default behavior does not fit your needs. | |||
| */ | |||
| @ExperimentalSettingsImplementation | |||
| public class KeychainSettings(vararg defaultProperties: Pair<CFStringRef?, CFTypeRef?>) : Settings { | |||
| public class KeychainSettings @ExperimentalSettingsApi constructor(vararg defaultProperties: Pair<CFStringRef?, CFTypeRef?>) : | |||
There was a problem hiding this comment.
I'm a little ambivalent about how I want to handle the fact that we directly expose a @ExperimentalForeignApi-annotated type in this constructor. (I think this is the only place in the codebase where that happens in public API, unless there are others I missed). I think the natural thing to do would be to re-apply the annotation, but it's not applicable to constructors. So I landed on marking it @ExperimentalSettingsApi instead. This lets the rest of the class go stable without depending on Kotlin stabilizing these APIs.
…ters, for platforms where it exists.
vanniktech
approved these changes
Aug 20, 2023
multiplatform-settings-serialization/src/commonMain/kotlin/SettingsSerialization.kt
Show resolved
Hide resolved
multiplatform-settings/src/appleMain/kotlin/com/russhwolf/settings/KeychainSettings.kt
Outdated
Show resolved
Hide resolved
Also tweaks doc-related test-case
Includes Kotlin 1.9.10, AGP 8.1.2, Gradle 8.3, et al Also migrate Android to use gradle namespace config and remove AndroidManifest files where unneeded.
|
Sample app build failure is expected right now. Updates in-progress in there. |
Also remove JavaFX CI config in preparation for sample updates
…ings/KeychainSettings.kt Co-authored-by: Niklas Baudy <niklas.baudy@vanniktech.de>
Move things to recent AGP and JDK Remove tornado-fx sample
Just following what’s here https://developer.android.com/jetpack/compose/setup#kotlin
This is (copy/paste) based on compose Android app, but deliberately doesn't share code for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains changes that will be released as version 1.1. It includes fixes for issues #81 (superceding PR #117), #142, #157, #160, and #162.
TODO: