Fix crash when creating 'KeychainSettings' without name on mac. #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case with creating
KeychainSettings
on Mac with no name and callingkeys
variable. BecausekSecAttrService
is not set you get a bunch of random values which might not havekSecAttrAccount
set so the call fails withNullPointerException
. Not sure if the fix style and new test assertion work for you, just wanted to raise the issue. Tested on m2 mac.