Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Renderer interface to satisfy go lint #240

Closed
mholt opened this issue Feb 14, 2016 · 4 comments
Closed

Change Renderer interface to satisfy go lint #240

mholt opened this issue Feb 14, 2016 · 4 comments

Comments

@mholt
Copy link

mholt commented Feb 14, 2016

I know this sounds a bit pedantic, but the Renderer interface has two methods that golint complains about: BlockHtml and RawHtmlTag. It suggests BlockHTML and RawHTMLTag.

FWIW I'm working to improve our score on Go Report Card... 馃槃
@dmitshur
Copy link
Collaborator

It's a valid issue, but I'm afraid it might be a non-starter because it'd invalidate all implementations of the interface, which is a huge breaking API change. It's definitely not worth the cost to fix 2 minor lint issues.

I think this is an issue that should be resolved with the v2 work which will break API compatibility and make many other desired improvements. See #218.

@mholt
Copy link
Author

mholt commented Feb 14, 2016

Version 2 sounds good to me 馃憤

mholt added a commit to caddyserver/caddy that referenced this issue Mar 26, 2016
@mholt
Add golint and ineffassign to CI scripts
7271b57 
golint is not part of the tests since our Markdown dependency defines
an interface that is not lint-compliant (unfortunately).
See russross/blackfriday#240
@Ambrevar
Copy link

Ambrevar commented Oct 5, 2016

This issue can be closed I believe.

@dmitshur
Copy link
Collaborator

dmitshur commented Oct 5, 2016

Confirmed, no longer an issue in v2, which this issue was tracking.

https://goreportcard.com/report/gopkg.in/russross/blackfriday.v2#golint

Closing.

@dmitshur dmitshur closed this as completed Oct 5, 2016
@francislavoie francislavoie mentioned this issue Apr 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mholt @Ambrevar @dmitshur