Add support for a bunch more safe HTML element tags, and bring them into... #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know whether you want more tests for the various elements, it seemed a bit silly to add a test for each element to me, but wouldn't be hard to add some more. |
|
Yeah, testing every element is silly, we'll end up having the same list of elements in code and in tests. What we really need is some combinatorial testing of sanitizer with other flags, but that's a whole different story. |
rtfb
added a commit
that referenced
this pull request
May 1, 2014
Add support for a bunch more safe HTML element tags, and bring them into...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... some order.