Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huge speed increase #3188

Open
jondot opened this issue Feb 17, 2020 · 8 comments
Open

huge speed increase #3188

jondot opened this issue Feb 17, 2020 · 8 comments
Labels
E-hard fun A technically challenging issue with high impact S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@jondot
Copy link

jondot commented Feb 17, 2020

Wow! thanks team. Just updated after 2-3 weeks of not updating, I'm getting head-spinning speed increase ❤️

Feel free to close -- this is just feedback and to say thanks!

@matklad
Copy link
Member

matklad commented Feb 17, 2020

Thanks <3 !

I guess we need to close this once we regress performance back :D

@matklad matklad added E-hard fun A technically challenging issue with high impact labels Feb 17, 2020
@bjorn3
Copy link
Member

bjorn3 commented Feb 17, 2020

Should I add std::thread::sleep_ms(10_000) to the main loop to fix this? :)

@matklad
Copy link
Member

matklad commented Feb 17, 2020

That's too easy: I suggest recompiling all the code with cranelift on every keystroke :-)

@bjorn3
Copy link
Member

bjorn3 commented Feb 17, 2020

That's even better! That would increase the quality of my code, because it will be tested on more projects.

Another idea would be to compile rust-analyzer itself using the tls branch of cg_clif. (I should actually try that)

@matklad
Copy link
Member

matklad commented Feb 17, 2020

Right, the current workaround is to compile rust-analyzer in debug mode :)

Also, I'll unsubscribe myself from this issue, otherwise I'll continue making silly jokes indefinitely (which probably will actually help with not making rust-analyzer slower...)

@jondot
Copy link
Author

jondot commented Feb 17, 2020

🤣

@StackDoubleFlow
Copy link

This is creating real issues with my procrastination workflow. pls fix

@jondot
Copy link
Author

jondot commented Nov 19, 2020

Hey all,
Just wanted to bump this -- and say I've just experienced a huge speed bump again.
I'm working on the same project as in the last 1.5 years, and now I'm getting code completions as fast as Golang code completion (which is crazy!).
I'm now completely happy with the experience!

@lnicola lnicola added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-hard fun A technically challenging issue with high impact S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

No branches or pull requests

5 participants