Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not implement persisting analysis results to disk #607

Closed
matklad opened this issue Jan 23, 2019 · 1 comment
Closed

Do not implement persisting analysis results to disk #607

matklad opened this issue Jan 23, 2019 · 1 comment

Comments

@matklad
Copy link
Member

matklad commented Jan 23, 2019

This is an issue to document a negative design decision.

Originally I've envisioned saving analysis results to disk, to improve start up time. However, after reading rust-lang/rfcs#1317 (comment) I am no convinced that it's better to keep away from disks unless we are absolutely pressed.

  • it is a ton of complexity
  • we should make analysis lazy enough and compact enough such that keeping stuff in memory is not too much of a burden.
@matklad matklad closed this as completed Jan 23, 2019
@matklad
Copy link
Member Author

matklad commented Jan 23, 2019

We don't have persistence anyway, so closing as fixed :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant