Migrate to edition 2021 #10607
Merged
Migrate to edition 2021 #10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Did you run |
kjeremy
reviewed
Oct 21, 2021
| @@ -8,7 +8,7 @@ use xshell::{cmd, pushd}; | |||
| use crate::flags; | |||
|
|
|||
| // Latest stable, feel free to send a PR if this lags behind. | |||
| const REQUIRED_RUST_VERSION: u32 = 55; | |||
| const REQUIRED_RUST_VERSION: u32 = 56; | |||
There was a problem hiding this comment.
Can we enforce this with the new [package] rust-version going forward?
There was a problem hiding this comment.
We could though if I see this right we don't fail on a version mismatch, we just print an error and continue.
|
I did run |
|
bors r+ |
lnicola
reviewed
Oct 23, 2021
| @@ -350,7 +350,7 @@ fn test_format_document_2018() { | |||
| [package] | |||
| name = "foo" | |||
| version = "0.0.0" | |||
| edition = "2018" | |||
| edition = "2021" | |||
There was a problem hiding this comment.
This doesn't matter, but this test was written specifically for 2018 (test_format_document_2018).
There was a problem hiding this comment.
Oh ye, we should revert that still
bors bot
added a commit
that referenced
this pull request
Oct 24, 2021
10624: minor: revert edition change in test r=lnicola a=lnicola Fixes #10607 (comment) Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.