-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to edition 2021 #10607
Migrate to edition 2021 #10607
Conversation
|
Did you run |
@@ -8,7 +8,7 @@ use xshell::{cmd, pushd}; | |||
use crate::flags; | |||
|
|||
// Latest stable, feel free to send a PR if this lags behind. | |||
const REQUIRED_RUST_VERSION: u32 = 55; | |||
const REQUIRED_RUST_VERSION: u32 = 56; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enforce this with the new [package] rust-version
going forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could though if I see this right we don't fail on a version mismatch, we just print an error and continue.
I did run |
bors r+ |
@@ -350,7 +350,7 @@ fn test_format_document_2018() { | |||
[package] | |||
name = "foo" | |||
version = "0.0.0" | |||
edition = "2018" | |||
edition = "2021" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't matter, but this test was written specifically for 2018 (test_format_document_2018
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ye, we should revert that still
10624: minor: revert edition change in test r=lnicola a=lnicola Fixes #10607 (comment) Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
No description provided.