Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: remove FnFlags::IS_IN_EXTERN_BLOCK #11924

Merged
merged 1 commit into from
Apr 7, 2022
Merged

internal: remove FnFlags::IS_IN_EXTERN_BLOCK #11924

merged 1 commit into from
Apr 7, 2022

Conversation

jonas-schievink
Copy link
Contributor

This flag was determined purely based on the AST, which cannot work reliably since macros are allowed in extern blocks (in which case the function would not have an extern block parent in the AST).

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 7, 2022

@bors bors bot merged commit 8765baa into rust-lang:master Apr 7, 2022
@jonas-schievink jonas-schievink deleted the rm-is-in-extern-block-flag branch April 7, 2022 13:36
@lnicola
Copy link
Member

lnicola commented Apr 7, 2022

We might need to do something similar for IS_UNSAFE, as seen in #11845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants