Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export lc.LanguageClient from VSCode extension #12053

Merged
merged 1 commit into from Apr 22, 2022

Conversation

willcrichton
Copy link
Contributor

As described in this Zulip thread, I would like to experiment with using Rust Analyzer's language server inside another VSCode extension, Flowistry. My current use case is to use one of Rust Analyzer's assists (extract function).

This PR would enable that experimentation by exporting the lc.LanguageClient from the activate function, which allows other extensions to access it. This PR does not commit RA to any stability guarantees about the language client, similar to how rustc exports an unstable API.

@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 22, 2022

📌 Commit d607c1b has been approved by jonas-schievink

@bors
Copy link
Collaborator

bors commented Apr 22, 2022

⌛ Testing commit d607c1b with merge b6b5214...

@bors
Copy link
Collaborator

bors commented Apr 22, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing b6b5214 to master...

@bors bors merged commit b6b5214 into rust-lang:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants