fix: doc url link type #12150
Merged
fix: doc url link type #12150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veykril
reviewed
May 4, 2022
crates/hir-def/src/attr.rs
Outdated
Comment on lines
858
to
860
| if !self.exists() { | ||
| return None; | ||
| } |
There was a problem hiding this comment.
This check is actually unnecessary
| @@ -853,6 +853,23 @@ impl<'attr> AttrQuery<'attr> { | |||
| .iter() | |||
| .filter(move |attr| attr.path.as_ident().map_or(false, |s| s.to_smol_str() == key)) | |||
| } | |||
|
|
|||
| pub fn find_string_value_in_tt(self, key: &'attr str) -> Option<&SmolStr> { | |||
There was a problem hiding this comment.
Let's add a comment showing an example for what this specifically does (as the name is not too descriptive, but I also do not have a better one). Something like
/// #[doc(html_root_url = "url")]
/// ^^^^^^^^^^^^^ key
should suffice
Guess you have to type exact |
|
@bors delegate+ |
|
✌️ @rainy-me can now approve this pull request |
yue4u
force-pushed
the
feat/fix-doc-url-links
branch
from
594e4dd
to
ddff1b2
Compare
|
@bors r+ |
|
📌 Commit ddff1b2 has been approved by |
|
☀️ Test successful - checks-actions |
|
changelog fix fix keyword doc links in hover
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #12033
I did some debugging and found the cause looks like to be some doc links'
LinkTypeare kept asShortcutwhich don't make sense for url links.This PR should resolve both problems in the origin issue, but aside this PR, more work are needed for doc_links.
about
LinkType: https://github.com/raphlinus/pulldown-cmark/blob/f29bd1e228913690e5092c9594e4e607423ff0aa/src/lib.rs#L191-L210