Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear cargo check diagnostics when turning off flycheck #12325

Merged
merged 1 commit into from May 20, 2022
Merged

fix: Clear cargo check diagnostics when turning off flycheck #12325

merged 1 commit into from May 20, 2022

Conversation

jonas-schievink
Copy link
Contributor

Previously stale diagnostics were left over indefinitely when turning off "Check on Save" while diagnostics are present.

@jonas-schievink
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented May 20, 2022

📌 Commit 3e356c1 has been approved by jonas-schievink

@bors
Copy link
Collaborator

bors commented May 20, 2022

⌛ Testing commit 3e356c1 with merge c73513f...

@jonas-schievink jonas-schievink changed the title fix: Clear cargo check diagnostics when flycheck is turned off fix: Clear cargo check diagnostics when turning off flycheck May 20, 2022
@bors
Copy link
Collaborator

bors commented May 20, 2022

☀️ Test successful - checks-actions
Approved by: jonas-schievink
Pushing c73513f to master...

@bors bors merged commit c73513f into rust-lang:master May 20, 2022
@jonas-schievink jonas-schievink deleted the clear-check-diags branch May 20, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants