Expand docs section on Visual Studio to mention all three available extensions #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nalyzer extensions for that IDE.
rustbot
added
the
S-waiting-on-review
|
How did we get from no extensions to three extensions? 😀 Including the license looks a bit weird (we don't do it for the other editor plugins), but I don't feel strongly about this. |
Hmmm. I neglected to review the document to see if any of the other listed plugins are closed source. That said, my only goal here was to err on the side of appropriate disclosure and fairness. If the maintainers here decide they want me to remove the license info, I will have no objection. |
lnicola
approved these changes
Feb 1, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR (#14012) by @parthopdas added mention of rust-analyzer.vs, his extension for Visual Studio 2022. I am submitting this PR to request that our extension (SourceGear Rust) be mentioned in that section as well, and also, for completeness, the VS_RustAnalyzer extension, by @cchharris.
Our extension is closed source, so I have clearly disclosed that. For consistency, I included brief mention of the licenses for the other two options as well. Also for the sake of consistency, I added marketplace and GitHub links for all 3.
The previously added paragraph by @parthopdas about his extension has been left intact.