Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the sysroot field in JsonProject #15014

Merged
merged 1 commit into from Jun 9, 2023

Conversation

Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Jun 8, 2023

rust-analyzer supports both sysroot and sysroot_src in rust-project.json. Document sysroot and show example values for both fields.

rust-analyzer supports both `sysroot` and `sysroot_src` in
`rust-project.json`. Document `sysroot` and show example values for
both fields.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2023
@Veykril
Copy link
Member

Veykril commented Jun 9, 2023

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 9, 2023

📌 Commit 5da1423 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 9, 2023

⌛ Testing commit 5da1423 with merge 425619d...

@bors
Copy link
Collaborator

bors commented Jun 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 425619d to master...

@bors bors merged commit 425619d into rust-lang:master Jun 9, 2023
10 checks passed
@Wilfred Wilfred deleted the document_sysroot branch June 9, 2023 21:03
Wilfred added a commit to Wilfred/rust-analyzer that referenced this pull request Feb 13, 2024
These were documented in rust-lang#15014 in the manual, but this definition
wasn't updated to match.
bors added a commit that referenced this pull request Feb 14, 2024
Update JsonProject to include optional fields

These were documented in #15014 in the manual, but this definition wasn't updated to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants