Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge of unwraps #15180

Merged
merged 2 commits into from Jun 30, 2023
Merged

Purge of unwraps #15180

merged 2 commits into from Jun 30, 2023

Conversation

alibektas
Copy link
Member

Removes unnecessary unwraps that I have overlooked in #15101 ( fixes #15176 )

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2023
.as_ref()
})();

if resops.is_none() || !resops.unwrap().contains(&kind) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if resops.is_none() || !resops.unwrap().contains(&kind) {
if !matches!(resops, Some(resops) if resops.contains(&kind)) {

@Veykril
Copy link
Member

Veykril commented Jun 30, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

📌 Commit cfbeb66 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

⌛ Testing commit cfbeb66 with merge 7a3991a...

@bors
Copy link
Collaborator

bors commented Jun 30, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 7a3991a to master...

@bors bors merged commit 7a3991a into rust-lang:master Jun 30, 2023
10 checks passed
@alibektas alibektas deleted the 15176 branch June 30, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assists are broken
4 participants