internal: SCIP: Qualify parameters by the containing function

[Wilfred]

SCIP requires symbols to be unique, but multiple functions may have a parameter with the same name. Qualify parameters according to the containing function.

[Veykril]

Hmm, that makes me wonder what should be done with the following snippet:

fn f() {
	let x = 0;
	let x = 1;
}

?
@bors r+

[bors]

📌 Commit edabffb has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit edabffb with merge 27e2eea...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 27e2eea to master...

[Wilfred]

@Veykril for locals specifically, they get a unique number, so that case works:

rust-analyzer/crates/rust-analyzer/src/cli/scip.rs

Lines 76 to 81 in 6918eb6

	let mut new_local_symbol = || {
	let new_symbol = scip::types::Symbol::new_local(local_count);
	local_count += 1;
	new_symbol
	};

However, you can still get name clashes for parameters, if you have nested functions or lambdas.