fix: rewrite DeMorgan assist #15410
Merged
fix: rewrite DeMorgan assist #15410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
alibektas
changed the title
Veykril
reviewed
Aug 8, 2023
Veykril
reviewed
Aug 8, 2023
alibektas
force-pushed
the
15240/invalid-demorgan
branch
from
446c615
to
17f3055
Compare
|
Since there won't be any |
Veykril
approved these changes
Aug 15, 2023
|
@bors r+ |
|
☀️ Test successful - checks-actions |
lnicola
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15239 , #15240 . This PR is a rewrite of the DeMorgan assist that essentially rids of all the string manipulation and modifies syntax trees to apply demorgan on a binary expr. The main reason for the rewrite is that I wanted to use
Expr::needs_parens_inmethod to see if the expr on which the assist is applied would still need the parens it had once the parent expression's operator had equal precedence with that of the expression. I used.clone_(subtree|for_update)left and right and probably more than I should have, so I would also be happy to hear how I could have prevented redundant cloning.