Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix only_types config filtering out traits from world symbols #15445

Merged
merged 1 commit into from Aug 12, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Aug 12, 2023

It is a bit confusing that this apparently did not filter every trait out though...

Closes #15444
Closes #15200

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2023
@Veykril
Copy link
Member Author

Veykril commented Aug 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

📌 Commit beec372 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

⌛ Testing commit beec372 with merge d62f854...

bors added a commit that referenced this pull request Aug 12, 2023
fix: Fix `only_types` config filtering out traits from world symbols

It is a bit confusing that this apparently did not filter every trait out though...

Closes #15444
@bors
Copy link
Collaborator

bors commented Aug 12, 2023

💔 Test failed - checks-actions

@Veykril
Copy link
Member Author

Veykril commented Aug 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

📌 Commit d6d188f has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

⌛ Testing commit d6d188f with merge 6cf06c1...

@bors
Copy link
Collaborator

bors commented Aug 12, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 6cf06c1 to master...

@bors bors merged commit 6cf06c1 into rust-lang:master Aug 12, 2023
10 checks passed
@Veykril Veykril deleted the worl-symbols-traits branch August 14, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traits no longer show up in VSCode workspace symbol search world symbol query does not see database traits
3 participants